Publication Content Type is double-encoding spaces in a file name URL leading to a 404

[JoeLutovsky]

Problem/Motivation

Publication Content Type URL is not working properly:

Example publication with this issue: https://sbar.arizona.edu/publication/guayule-growth-yield-responses-deficit-irrigation-strategies-u-s-desert

Describe the bug

If you click on the main link in the body of this publication it leads to a 404. It should be linking to the PDF that's attached to the Publication content type.

To Reproduce

Steps to reproduce the behavior:

Add a file with spaces in the filename to the Publication File field in a publication.

Proposed resolution

I was discussion this on Slack with Dana and Brian.

Brian said:

"The problem appears to be that the spaces in the filename are being encoded twice: first the space characters were encoded as %20 and then those instances of %20 were encoded again as %2520, since %25 is the code for %. If you edit that broken URL to change the spaces back to %20, the file will load successfully.
I’m not sure how the link is being encoded twice, but maybe this line in az_publication.module needs some attention. Here is the source for that createFileUrl function."

Expected behavior

Link should lead to the attached PDF and not a 404.

Screenshots

If applicable, add screenshots to help explain your problem. (Need a tool to share screenshots or screencasts as URLs? Try monosnap

Desktop (please complete the following information):

• OS: Windows and MacOS
• Browser: all

Additional context

Add any other context about the problem here.