Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stem dict replicates intent. Reduce edges also replicates entity. #436

Merged
merged 1 commit into from
May 4, 2020

Conversation

jesus-seijas-sp
Copy link
Contributor

Pull Request Template

PR Checklist

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

When using stem dict, the intent was classified twice.
Reduce edges now takes into account that the developer can introduce the same text several times

@jesus-seijas-sp jesus-seijas-sp mentioned this pull request Apr 27, 2020
@coveralls
Copy link

coveralls commented Apr 27, 2020

Pull Request Test Coverage Report for Build 1546

  • 2 of 4 (50.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 74.643%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/ner/src/reduce-edges.js 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
packages/ner/src/reduce-edges.js 1 31.94%
Totals Coverage Status
Change from base Build 1524: -0.07%
Covered Lines: 4623
Relevant Lines: 5918

💛 - Coveralls

@jesus-seijas-sp jesus-seijas-sp merged commit 0758ea0 into master May 4, 2020
@jesus-seijas-sp jesus-seijas-sp deleted the feature/fix_stem_dict branch June 15, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants