Merge pull request #436 from axa-group/feature/fix_stem_dict

fix: stem dict replicates intent. Reduce edges also replicates entity.
axa-group · May 4, 2020 · 0758ea0 · 0758ea0
2 parents 0f08809 + 5d08163
commit 0758ea0
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 32 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/ner/src/reduce-edges.js b/packages/ner/src/reduce-edges.js
@@ -36,6 +36,16 @@ function runDiscard(srcEdge, srcOther, useMaxLength) {
       other.len <= edge.len
     ) {
       // Do nothing! entities have same priority
+      if (
+        other.start === edge.start &&
+        other.end === edge.end &&
+        other.type === 'enum' &&
+        edge.type === 'enum' &&
+        other.entity === edge.entity &&
+        other.option === edge.option
+      ) {
+        other.discarded = true;
+      }
     } else if (
       (useMaxLength ||
         other.entity === edge.entity ||

diff --git a/packages/nlu/src/domain-manager.js b/packages/nlu/src/domain-manager.js
@@ -268,7 +268,9 @@ class DomainManager extends Clonable {
       });
       const intents = Object.keys(this.intentDict);
       for (let i = 0; i < intents.length; i += 1) {
-        classifications.push({ intent: intents[i], score: 0 });
+        if (intents[i] !== resolved.intent) {
+          classifications.push({ intent: intents[i], score: 0 });
+        }
       }
       return { domain: resolved.domain, classifications };
     }