Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added possible iOS double tab fix #394

Merged
merged 3 commits into from
Apr 6, 2018
Merged

added possible iOS double tab fix #394

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69b0b63
added possible iOS double tab fix
AndyOGo Apr 5, 2018
59939ac
seems this fixes it
AndyOGo Apr 5, 2018
59c78d3
undo bg color shortcut fix
AndyOGo Apr 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/m-button/mixins/_button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,9 @@

display: block;

width: 0;
// fix iOS double tap for :hover
// zero width is considered hidden
width: 0.001px;
Copy link
Author

@AndyOGo AndyOGo Apr 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LucaMele
@TheDadi
@sventschui
It would be possible to target these styles only at ios devices (though it's a big list of media queries...) 🤔
http://stephen.io/mediaqueries/

Better list for iOS devices:
https://css-tricks.com/snippets/css/media-queries-for-standard-devices/

Excluding iOS:
https://jeffclayton.wordpress.com/2014/07/28/css-hack-anything-but-ios/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And computation of decimal pixel values should be tested:
http://cruft.io/posts/percentage-calculations-in-ie/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LucaMele
@TheDadi
@sventschui
According to my manual browserstack tests, decimal point rounding does not seem to be an issue :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will run few tests and then ok :)

height: 550px;
content: '';

Expand Down