-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added possible iOS double tab fix #394
Conversation
width: 0; | ||
// fix iOS double tap for :hover | ||
// zero width is considered hidden | ||
width: 0.001px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LucaMele
@TheDadi
@sventschui
It would be possible to target these styles only at ios devices (though it's a big list of media queries...) 🤔
http://stephen.io/mediaqueries/
Better list for iOS devices:
https://css-tricks.com/snippets/css/media-queries-for-standard-devices/
Excluding iOS:
https://jeffclayton.wordpress.com/2014/07/28/css-hack-anything-but-ios/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And computation of decimal pixel values should be tested:
http://cruft.io/posts/percentage-calculations-in-ie/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LucaMele
@TheDadi
@sventschui
According to my manual browserstack tests, decimal point rounding does not seem to be an issue :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will run few tests and then ok :)
@LucaMele If so, we would need to do it manually now. And may add a hotfix feature to our release script. |
When is the plan for develop merge? |
but yes it might be better to treat it as HF and add it to the release |
6512b13
to
59c78d3
Compare
Fixes #385 .
Changes proposed in this pull request:
:hover
I hope this CSS-Solution will work, another reliable fix would be using#290tap
events implemented byType of change
How Has This Been Tested?
Tested the Expandable Container at local axa.ch mock server at browserstack on:
Checklist: