Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added possible iOS double tab fix #394

Merged
merged 3 commits into from
Apr 6, 2018
Merged

Conversation

AndyOGo
Copy link

@AndyOGo AndyOGo commented Apr 5, 2018

Fixes #385 .

Changes proposed in this pull request:

  • Fixes iOS double tab issue for :hover

I hope this CSS-Solution will work, another reliable fix would be using tap events implemented by #290

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested the Expandable Container at local axa.ch mock server at browserstack on:

  • iPhones and iPad from iOS 7+ up to 11
  • Edge 16, 14, IE 11
  • Lastest and random desktop browsers at windows, macOS
  • Android 5, 7 Samsung Galaxies

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

width: 0;
// fix iOS double tap for :hover
// zero width is considered hidden
width: 0.001px;
Copy link
Author

@AndyOGo AndyOGo Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LucaMele
@TheDadi
@sventschui
It would be possible to target these styles only at ios devices (though it's a big list of media queries...) 🤔
http://stephen.io/mediaqueries/

Better list for iOS devices:
https://css-tricks.com/snippets/css/media-queries-for-standard-devices/

Excluding iOS:
https://jeffclayton.wordpress.com/2014/07/28/css-hack-anything-but-ios/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And computation of decimal pixel values should be tested:
http://cruft.io/posts/percentage-calculations-in-ie/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LucaMele
@TheDadi
@sventschui
According to my manual browserstack tests, decimal point rounding does not seem to be an issue :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will run few tests and then ok :)

@AndyOGo AndyOGo requested a review from sventschui April 5, 2018 14:18
@AndyOGo
Copy link
Author

AndyOGo commented Apr 5, 2018

@LucaMele
Guess this should actually be a hotfix, merged directly into master?

If so, we would need to do it manually now. And may add a hotfix feature to our release script.

@LucaMele
Copy link
Contributor

LucaMele commented Apr 6, 2018

When is the plan for develop merge?

@LucaMele
Copy link
Contributor

LucaMele commented Apr 6, 2018

but yes it might be better to treat it as HF and add it to the release

@AndyOGo AndyOGo changed the base branch from develop to master April 6, 2018 07:48
@AndyOGo AndyOGo force-pushed the bugfix/ios-button-double-tap branch from 6512b13 to 59c78d3 Compare April 6, 2018 07:50
@AndyOGo AndyOGo merged commit 540af74 into master Apr 6, 2018
@AndyOGo AndyOGo deleted the bugfix/ios-button-double-tap branch April 6, 2018 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants