Allow manually remove invalid snapshots on restore #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanyuel
force-pushed
the
snapshot-restore
branch
from
606c29b to
27aaa1c
Compare
|
Can you provide details on how you tested this? |
Check the updated Testing section in PR description |
sparr
added a commit
to sparr/soci-snapshotter
that referenced
this pull request
Feb 1, 2023
Signed-off-by: Clarence "Sparr" Risher <[email protected]>
sparr
added a commit
to sparr/soci-snapshotter
that referenced
this pull request
Feb 1, 2023
Signed-off-by: Clarence "Sparr" Risher <[email protected]>
sparr
added a commit
to sparr/soci-snapshotter
that referenced
this pull request
Feb 2, 2023
Signed-off-by: Clarence "Sparr" Risher <[email protected]>
sparr
added a commit
that referenced
this pull request
Feb 2, 2023
Signed-off-by: Clarence "Sparr" Risher <[email protected]>
sparr
added a commit
to sparr/soci-snapshotter
that referenced
this pull request
Feb 3, 2023
Signed-off-by: Clarence "Sparr" Risher <[email protected]>
sparr
added a commit
to sparr/soci-snapshotter
that referenced
this pull request
Feb 6, 2023
Signed-off-by: Clarence "Sparr" Risher <[email protected]>
sparr
added a commit
to sparr/soci-snapshotter
that referenced
this pull request
Feb 6, 2023
Signed-off-by: Clarence "Sparr" Risher <[email protected]>
Kern--
previously approved these changes
Feb 8, 2023
turan18
previously approved these changes
Feb 13, 2023
Signed-off-by: Hanyue Liang <[email protected]>
hanyuel
dismissed stale reviews from turan18, sbuckfelder, and Kern--
via
a12bd81
hanyuel
force-pushed
the
snapshot-restore
branch
from
27aaa1c to
a12bd81
Compare
turan18
approved these changes
Feb 13, 2023
Kern--
approved these changes
Feb 13, 2023
sparr
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: closes #93
The problem that #93 tries to fix is that if the snapshotter crashes, it won't be able to restart because the snapshotter won't be able to restore the remote snapshots (this will error out), so it will crash again and again.
Description of changes:
cherry-pick containerd/stargz-snapshotter#901
Testing performed:
I was not able to reproduce the problem (details above) by killing (SIGKILL-ing) the soci-snapshotter-grpc process when the container is running. I might have repro'd once... so I was not able to verify this PR fixes the problem. But I think this PR is still worth merging considering 1) it's defensive programming 2) it's cherrypicked from stargz repo.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.