Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manually remove invalid snapshots on restore #93

Closed
vkuzniet opened this issue Oct 4, 2022 · 1 comment · Fixed by #345
Closed

Allow manually remove invalid snapshots on restore #93

vkuzniet opened this issue Oct 4, 2022 · 1 comment · Fixed by #345
Assignees
Labels
feature New feature or request stability Decreases the likelihood for introducing bugs

Comments

@vkuzniet
Copy link
Contributor

vkuzniet commented Oct 4, 2022

Is your feature request related to a problem? Please describe.
On restart, soci-snapshotter-grpc doesn't start if one of the snapshots cannot restore. This makes impossible to manually remove images and snapshots (e.g. by using ctr).

Describe the solution you'd like
Cherrypick containerd/stargz-snapshotter#901

Describe alternatives you've considered

Additional context

@vkuzniet vkuzniet added the feature New feature or request label Oct 4, 2022
@rdpsin rdpsin moved this to ❓ Ungroomed in soci-snapshotter Oct 6, 2022
@rdpsin rdpsin moved this from ❓ Ungroomed to 📋 Backlog in soci-snapshotter Oct 6, 2022
@Kern-- Kern-- added the stability Decreases the likelihood for introducing bugs label Dec 13, 2022
@hanyuel hanyuel self-assigned this Jan 20, 2023
@hanyuel
Copy link
Contributor

hanyuel commented Jan 26, 2023

This problem that this issue tries to fix is that if the snapshotter crashes, it won't be able to restart because the snapshotter won't be able to restore the remote snapshots (this will error out), so it will crash again and again.

I was not able to reproduce the problem by killing (SIGKILL-ing) the soci-snapshotter-grpc process when the container is running. I might have repro'd once... Here are the steps I did:

  1. start soci-snapshott-grpc
  2. soci image rpull $IMAGE
  3. soci run $IMAGE
  4. sudo kill -9 process-id-of-soci-snapshotter-grpc
  5. ctr i rm $IMAGE
  6. repeat step 1,2,3

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in soci-snapshotter Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request stability Decreases the likelihood for introducing bugs
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants