fix: temporarily bypass httpchecksum traits until full flexible checksum support is available #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sum support is available
|
A new generated diff is ready to view: __generated-main...__generated-fix-bypass-httpchecksum |
aajtodd
approved these changes
Mar 22, 2022
Yes, good catch. |
|
A new generated diff is ready to view: __generated-main...__generated-fix-bypass-httpchecksum |
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view: __generated-main...__generated-fix-bypass-httpchecksum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(none)
Description of changes
Without this change, the latest S3 model cannot be included in the SDK since it replaces
httpChecksumRequredwithhttpChecksumfor flexible checksum support. This is a temporary workaround to allow consuming the latest S3 model. Full support for flexible checksums will come in #557.Companion PR: smithy-kotlin#608
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.