Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: temporarily handle httpchecksum trait the same as httpchecksumrequired #608

Merged
merged 2 commits into from
Mar 22, 2022
Merged

fix: temporarily handle httpchecksum trait the same as httpchecksumrequired #608

merged 2 commits into from
Mar 22, 2022

Conversation

ianbotsf
Copy link
Contributor

@ianbotsf ianbotsf commented Mar 21, 2022 •
edited
Loading

Issue #

(none)

Description of changes

Temporarily adds support for handling httpChecksum the same as httpChecksumRequired. This enables consuming the latest model changes from S3 without fully implementing flexible checksums. Full support will come in aws-sdk-kotlin#557.

Companion PR: aws-sdk-kotlin#558

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ianbotsf ianbotsf requested a review from aajtodd March 21, 2022 23:24
@ianbotsf ianbotsf requested a review from a team as a code owner March 21, 2022 23:24
@ianbotsf ianbotsf mentioned this pull request Mar 21, 2022
Merged
aajtodd
aajtodd approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@aajtodd aajtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is of course fine for now but eventually these are going to be mutually exclusive right?

@ianbotsf
Copy link
Contributor Author

This is of course fine for now but eventually these are going to be mutually exclusive right?

Not completely. httpChecksum will require additional handling but according to the spec httpChecksumRequired is now synonymous with httpChecksum { requestChecksumRequired = true }.

@aajtodd
Copy link
Contributor

aajtodd commented Mar 22, 2022 •
edited
Loading

This is of course fine for now but eventually these are going to be mutually exclusive right?

Not completely. httpChecksum will require additional handling but according to the spec httpChecksumRequired is now synonymous with httpChecksum { requestChecksumRequired = true }.

Right, I guess it depends on how we implement it and whether we remove the MD5 checksum middleware in favor of a more generic checksum middleware or not. We also will have to be careful to not register two different checksum middlewares.

@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ianbotsf ianbotsf merged commit 58d4642 into main Mar 22, 2022
@ianbotsf ianbotsf deleted the fix-bypass-httpchecksum branch March 22, 2022 17:32
aajtodd added a commit that referenced this pull request Feb 8, 2023
@aajtodd
refactor(rt): upstream HttpClientEngine interface changes (#608)
57708ce 
* refactor(rt): upstream HttpClientEngine interface changes

* replace default retry middleware with AWS specific component that sets retry headers

* add max attempts to retry header
aajtodd added a commit that referenced this pull request Feb 13, 2023
@aajtodd
refactor(rt): upstream HttpClientEngine interface changes (#608)
6ec30de 
* refactor(rt): upstream HttpClientEngine interface changes

* replace default retry middleware with AWS specific component that sets retry headers

* add max attempts to retry header
aajtodd added a commit that referenced this pull request Mar 11, 2024
@aajtodd
refactor(rt): upstream HttpClientEngine interface changes (#608)
7f350c6 
* refactor(rt): upstream HttpClientEngine interface changes

* replace default retry middleware with AWS specific component that sets retry headers

* add max attempts to retry header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aajtodd aajtodd aajtodd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianbotsf @aajtodd