Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate notification endpoint setup in pipeline generation #362

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Fix duplicate notification endpoint setup in pipeline generation #362

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
486dafa
Fix duplicate notification endpoint setup in pipeline generation
sbkok May 17, 2021
9882b93
Merge branch 'master' into fix/duplicate-adf-notifications-issue
StewartW Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...mbda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
from aws_cdk import (
core
)
from cdk_constructs import adf_notifications
from logger import configure_logger

from cdk_stacks.adf_default_pipeline import generate_adf_default_pipeline as generate_default_pipeline, PIPELINE_TYPE as DEFAULT_PIPELINE
Expand All @@ -21,9 +20,6 @@ def __init__(self, scope: core.Construct, stack_input: dict, **kwargs) -> None:
LOGGER.info('Pipeline creation/update of %s commenced', stack_input['input']['name'])
_pipeline_type = stack_input['input'].get('params', {}).get('type', DEFAULT_PIPELINE).lower()

if stack_input['input'].get('params', {}).get('notification_endpoint'):
stack_input['input']["topic_arn"] = adf_notifications.Notifications(self, 'adf_notifications', stack_input['input']).topic_arn

self.generate_pipeline(_pipeline_type, stack_input)

def generate_pipeline(self, _pipeline_type, stack_input):
Expand Down