Fix duplicate notification endpoint setup in pipeline generation #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** When generating a pipeline, the code optimization introduced by PR awslabs#285 broke the notification_endpoint configuration. When set, it would try to configure the notification in the main generator as well as in the default ADF pipeline generator. **What?** Removing the notification endpoint configuration from the main template, as that is replaced by the default ADF pipeline generator implementation.
StewartW
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When generating a pipeline, the code optimization introduced by PR #285
broke the notification_endpoint configuration. When set, it would try to
configure the notification in the main generator, as well as in the
default ADF pipeline generator.
What?
Removing the notification endpoint configuration from the main template,
as that is replaced by the default ADF pipeline generator
implementation.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.