Use non-global logger to avoid unexpected global log discarding #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kern--
reviewed
Feb 27, 2022
kzys
approved these changes
Feb 28, 2022
|
Can you squash the two commits into one? |
writes to the requested output , instead of changing the behavior of the standard logrus logger. Rename WithLogOutput to WithLogger to make this new behavior clearer. Use non-global logger to avoid unexpected global log discarding Reported in GoogleContainerTools/kaniko#1955 Changes in awslabs#309 made it possible for callers depending on this code as a Go library to redirect log output to ioutil.Discard to avoid spurious log statements. Unfortunately, because in that change the logger being used was the shared global logger.StandardLogger(), redirecting its output to ioutil.Discard to quiet ecr-login also disabled all logging using the shared global logger (like Kaniko does). Signed-off-by: Jason Hall <[email protected]>
imjasonh
force-pushed
the
non-global-logger
branch
from
631d7dc to
6251354
Compare
Kern--
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in GoogleContainerTools/kaniko#1955
Changes in #309 made it possible for callers depending on this code as a Go library to redirect log output to
ioutil.Discardto avoid spurious log statements.Unfortunately, because in that change the logger being used was the shared global logger.StandardLogger(), redirecting its output to
ioutil.Discardto quiet ecr-login also disabled all logging using the shared global logger (like Kaniko does). 🤦♂️Signed-off-by: Jason Hall [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.