Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing configurable logger to ECRHelper #308

Closed
hasheddan opened this issue Jan 20, 2022 · 1 comment
Closed

Support passing configurable logger to ECRHelper #308

hasheddan opened this issue Jan 20, 2022 · 1 comment

Comments

@hasheddan
Copy link

Currently the ECRHelper uses a global logger and emits error logs on events such as a failure to parse the server URL. An error here makes sense in the common case where a user is using the ECR Credentials Helper explicitly for a URL, such as in a Docker auth config file. However, if ECRHelper is being consumed in a chain of credentials (e.g. k8schain), this error simply means that we cannot retrieve ECR credentials for this specific image reference. Ideally, the logger used by ECRHelper could be configured such that an error logs like the one emitted in this case can be easily discarded without having to set the global logger output to discard.

I am happy to implement this change if maintainers are on board 👍🏻

@hasheddan
Copy link
Author

I believe this was fixed by #312! Thanks @imjasonh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant