Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update security-groups-for-pods.md #559

Merged
merged 1 commit into from
May 11, 2022
Merged

Update security-groups-for-pods.md #559

merged 1 commit into from
May 11, 2022

Conversation

joebowbeer
Copy link

Issue #, if available:

Fixes #557

Description of changes:

Improve guidance for terminationGracePeriodSeconds

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jimdial-aws jimdial-aws self-assigned this May 2, 2022
@abhipth
Copy link

abhipth commented May 10, 2022

lgtm! This limitation is fixed with v1.10.3 onward with this PR. Would appreciate if you could add this information as well. Thanks

@jimdial-aws jimdial-aws merged commit 0dffc40 into awsdocs:master May 11, 2022
@jimdial-aws
Copy link

Thank you for the contribution.

@joebowbeer
Copy link
Author

joebowbeer commented May 11, 2022

@abhipth Thanks for update. I'm sorry I didn't see it in time to update the PR:

Pods using security groups must not have terminationGracePeriodSeconds set to 0 in their pod spec. (The default value is 30.) This is because the Amazon EKS VPC CNI plugin [prior to v1.10.3] queries the API server to retrieve the pod IP address before deleting the pod network on the host. Without this setting, the plugin doesn't remove the pod network on the host.

In time, the entire paragraph can be deleted.

@joebowbeer joebowbeer deleted the patch-1 branch May 11, 2022 19:39
@jimdial-aws
Copy link

No worries, I'll add the text about the version. I'm also going to modify that sentence altogether, after speaking with the engineers. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve terminationGracePeriodSeconds guidance in SGP considerations
3 participants