Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve terminationGracePeriodSeconds guidance in SGP considerations #557

Closed
joebowbeer opened this issue May 2, 2022 · 0 comments · Fixed by #559
Closed

Improve terminationGracePeriodSeconds guidance in SGP considerations #557

joebowbeer opened this issue May 2, 2022 · 0 comments · Fixed by #559
Assignees
@jimdial-aws

Comments

@joebowbeer
Copy link

In Security groups for pods / considerations, the guidance regarding terminationGracePeriodSeconds is easily misunderstood:

Pods using security groups must contain terminationGracePeriodSeconds in their pod spec. This is because the Amazon EKS VPC CNI plugin queries the API server to retrieve the pod IP address before deleting the pod network on the host. Without this setting, the plugin doesn't remove the pod network on the host.

The problems with this statement are:

  1. terminatingGracePeriodSeconds has a default value of 30s; why does it have to be present in the "spec"?
  2. The actual condition to be avoided is terminatingGracePeriodSeconds=0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimdial-aws jimdial-aws

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update security-groups-for-pods.md
2 participants
@joebowbeer @jimdial-aws