add support for go-integrations overriding error code for error types #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
requested changes
Jul 9, 2021
...en/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/StructureGenerator.java
Outdated
Show resolved
Hide resolved
…or code from an error shape
skotambkar
force-pushed
the
change-errorcode
branch
from
4722634 to
ebf6e83
Compare
JordonPhillips
approved these changes
Jul 14, 2021
skmcgrail
approved these changes
Jul 14, 2021
jasdel
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AwsQueryErrortrait overrides the error code for an error type.https://awslabs.github.io/smithy/1.0/spec/aws/aws-query-protocol.html#aws-protocols-awsqueryerror-trait
This change allows us to override errorCode for a protocol generator, defaulting to error shape name as error code.