Updates the error code returned for Errors modeled with awsQueryError trait #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
requested review from
jasdel and
skmcgrail
and removed request for
jasdel
skotambkar
force-pushed
the
change-errorcode
branch
from
8eee773 to
75a22c9
Compare
JordonPhillips
approved these changes
Jul 14, 2021
jasdel
approved these changes
Jul 14, 2021
skmcgrail
approved these changes
Jul 14, 2021
jrichard8
pushed a commit
to jrichard8/aws-sdk-go-v2
that referenced
this pull request
Feb 14, 2022
… trait (aws#1333) * java codegen change to override getErrorCode method for awsQuery protocol and use AwsQueryError trait * generated clients and protocol test to use awsQueryError trait * remove hard coded error code from web identity provider test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change for clients using
awsQueryErrortrait.Note: CI will fail until aws/smithy-go#315 is merged.
This PR fixes SDK behavior to return error code modeled using awsQueryError trait, when
ErrorCode()method is called on an error type.Recommend reviewing per order of commit -
Commit 1 - Codegen changes.
Commit 2 - All generated client changes.
Commit 3 - Web identity provider test fix to not use hard coded error code.