add default provisioner to helm chart #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 0b65f71 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/618c5d308cc2e10008c74ea0 |
|
There seems to be an uninstall problem with helm and using CRDs. I'll have to dig into that more, but wanted to note this issue in the PR. |
ellistarn
reviewed
Nov 10, 2021
|
Check out #781 |
bwagner5
force-pushed
the
helm-default-provisioner
branch
from
eb198a2 to
0b65f71
Compare
ellistarn
approved these changes
Nov 11, 2021
3 tasks
|
@bwagner5 did this ever make it into a release? the template file and values block for this don't seem to exist in any tag other than 0.4.3. |
|
It did and then it was removed due to issues with Helm managing custom resources well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
#781
#784
2. Description of changes:
crdsdir per helm3 guidance so that CRD is sequenced before the provisioner3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.