-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm Chart Wishlist #781
Comments
Hey Steve,
Is there any thing you had in mind? Contributions are absolutely welcome. I'm not sure about the move to aws/eks-charts. Not all AWS charts live there, and it's becoming a bit of a monolith to maintain. Serving the karpenter chart from here helps keep everything nicely in sync with our release process. I'm open minded to proposals for alternatives. |
@ellistarn the chart doesn't follow idiomatic Helm patterns, but the big issue is having a CRD inside the chart. CRDs should be inside the special ./crds folder so they can (and should) be ignored via the Regarding the aws/eks-charts repo, it's a good discovery point. If it's becoming a monolith to maintain that's a problem with the process not something inherent to a central repo; I like the current release push model for things like the NTH chart but the actual chart release could be made independent to a repo tag. |
Are you able to swing by our working group to discuss eks-charts? It should be straightforward to point our CRD codegen to |
@ellistarn I'll try and join next week. |
This is now in v0.4.4. Please reopen (or a new issue) if there are more features you'd like added to the chart, |
Closing this as I think it has been fully resolved, feel free to re-open another issue if there are other specific changes desired. |
Tell us about your request
I'd like Karpenter to have an idiomatic Helm chart with all of the components in the correct place and the standard integration points available.
I'd also like to see the chart published to aws/eks-charts.
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
I'd like to install Karpenter but the current Helm chart doesn't have the right configuration exposed and the CRD is directly in the chart.
Are you currently working around this issue?
n/a
Additional context
I'd be more than happy to open a PR to update the chart.
Attachments
n/a
Community Note
The text was updated successfully, but these errors were encountered: