Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart Wishlist #781

Closed
stevehipwell opened this issue Nov 4, 2021 · 6 comments
Closed

Helm Chart Wishlist #781

stevehipwell opened this issue Nov 4, 2021 · 6 comments
Labels
feature New feature or request

Comments

@stevehipwell
Copy link
Contributor

Tell us about your request
I'd like Karpenter to have an idiomatic Helm chart with all of the components in the correct place and the standard integration points available.

I'd also like to see the chart published to aws/eks-charts.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
I'd like to install Karpenter but the current Helm chart doesn't have the right configuration exposed and the CRD is directly in the chart.

Are you currently working around this issue?
n/a

Additional context
I'd be more than happy to open a PR to update the chart.

Attachments
n/a

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@stevehipwell stevehipwell added the feature New feature or request label Nov 4, 2021
@ellistarn ellistarn changed the title Idiomatic Helm chart Helm Chart Wishlist Nov 4, 2021
@ellistarn
Copy link
Contributor

Hey Steve,
We're definitely interested in expanding our helm chart's capabilities. So far, we've expanded functionality on an as needed basis. I'm not sure what you mean by

components in the correct place and the standard integration points available.

Is there any thing you had in mind? Contributions are absolutely welcome.

I'm not sure about the move to aws/eks-charts. Not all AWS charts live there, and it's becoming a bit of a monolith to maintain. Serving the karpenter chart from here helps keep everything nicely in sync with our release process. I'm open minded to proposals for alternatives.

@stevehipwell
Copy link
Contributor Author

@ellistarn the chart doesn't follow idiomatic Helm patterns, but the big issue is having a CRD inside the chart. CRDs should be inside the special ./crds folder so they can (and should) be ignored via the helm upgrade --install --skip-crds.

Regarding the aws/eks-charts repo, it's a good discovery point. If it's becoming a monolith to maintain that's a problem with the process not something inherent to a central repo; I like the current release push model for things like the NTH chart but the actual chart release could be made independent to a repo tag.

@ellistarn
Copy link
Contributor

ellistarn commented Nov 4, 2021

Are you able to swing by our working group to discuss eks-charts?

It should be straightforward to point our CRD codegen to ./charts/karpenter/crds

@stevehipwell
Copy link
Contributor Author

@ellistarn I'll try and join next week.

@ellistarn
Copy link
Contributor

ellistarn commented Nov 25, 2021

This is now in v0.4.4. Please reopen (or a new issue) if there are more features you'd like added to the chart,

@tzneal
Copy link
Contributor

tzneal commented May 24, 2022

Closing this as I think it has been fully resolved, feel free to re-open another issue if there are other specific changes desired.

@tzneal tzneal closed this as completed May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants