Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry-pick(1.0.x): chore: update support for 1.31 (#7126) #7130

Merged
merged 2 commits into from
Sep 30, 2024
Merged

cherry-pick(1.0.x): chore: update support for 1.31 (#7126) #7130

merged 2 commits into from
Sep 30, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Sep 30, 2024

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner September 30, 2024 20:44
@jmdeal jmdeal requested a review from danxwang22 September 30, 2024 20:44
@coveralls
Copy link

coveralls commented Sep 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11114160784

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 79.368%
Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 11079084588: -0.03%
Covered Lines: 5955
Relevant Lines: 7503
💛 - Coveralls

@jmdeal
Copy link
Contributor Author

jmdeal commented Sep 30, 2024

/hold

Need to cp this over as well once it merges: #7131

@jmdeal jmdeal merged commit 687641c into aws:release-v1.0.x Sep 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschalo rschalo rschalo approved these changes

@danxwang22 danxwang22 Awaiting requested review from danxwang22 danxwang22 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmdeal @coveralls @rschalo @njtran