Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update support for 1.31 #7126

Merged
merged 5 commits into from
Sep 30, 2024
Merged

chore: update support for 1.31 #7126

merged 5 commits into from
Sep 30, 2024

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Sep 30, 2024

Fixes #N/A

Description
Update CI to use 1.31 and drop 1.25

How was this change tested?
here

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner September 30, 2024 15:17
@njtran njtran requested a review from edibble21 September 30, 2024 15:17
Copy link
Contributor Author

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 184e544
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66fb09515bbdd70008b24258

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-7239203d3bb0d08d66af611c2fd193d73fac7dc5.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-7239203d3bb0d08d66af611c2fd193d73fac7dc5" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

coveralls commented Sep 30, 2024

Pull Request Test Coverage Report for Build 11113597316

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.291%

Totals Coverage Status
Change from base Build 11097980525: 0.0%
Covered Lines: 5578
Relevant Lines: 6697

💛 - Coveralls

Copy link
Contributor Author

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-cef2a97ddb4dcacc12063122bd853f0073c0201c.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-cef2a97ddb4dcacc12063122bd853f0073c0201c" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal enabled auto-merge (squash) September 30, 2024 20:26
@jmdeal jmdeal merged commit ceac7a6 into aws:main Sep 30, 2024
17 checks passed
jmdeal added a commit to jmdeal/karpenter-provider-aws that referenced this pull request Sep 30, 2024
jmdeal added a commit to jmdeal/karpenter-provider-aws that referenced this pull request Sep 30, 2024
jmdeal added a commit that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants