Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(v1.0.x): fix: Correct the AMI selector label requirements for NVIDIA and Neuron Variants #7058

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Sep 23, 2024

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner September 23, 2024 20:08
@jmdeal jmdeal requested a review from danxwang22 September 23, 2024 20:08
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11001615497

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 79.405%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 91.67%
Totals Coverage Status
Change from base Build 10998907940: 0.01%
Covered Lines: 5957
Relevant Lines: 7502

💛 - Coveralls

@jmdeal jmdeal merged commit 32f1057 into aws:release-v1.0.x Sep 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants