fix: Correct the AMI selector label requirements for NVIDIA and Neuron variants

[bryantbiggs]

Fixes #N/A

Description

• Correct the AMI selector label requirements for NVIDIA and Neuron variants
  • Instances backed with NVIDIA GPUs should have the label karpenter.sh/instance-gpu-count
  • Instances backed with Neuron devices should have the label karpenter.sh/instance-accelerator-count

How was this change tested?

• make test

Does this change impact docs?

• Yes, PR includes docs updates
• Yes, issue opened: #
• No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[netlify]

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	00d59a0
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/66ecab7ae49bb90008c74406

[coveralls]

Pull Request Test Coverage Report for Build 10950107138

Details

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 83.01%

---

Totals
Change from base Build 10910984774:	0.02%
Covered Lines:	5521
Relevant Lines:	6651

---

💛 - Coveralls

[jmdeal]

LGTM 🚀

Looks like this slipped through because our currently supported AMIs don't differentiate between Nvidia and Neuron, so this swap doesn't change the end result. I'd be happy to merge and take a test for that case as a follow-up (separate Nvidia and Neuron AMIs, same AMI family), but also happy to take one here if you wanted to add one.

[bryantbiggs]

I'm dreadfully awful with go 😅 - give me 24 hours and let me see if I can add in tests for this

[bryantbiggs]

@jmdeal I tried a naive approach to check that the scheduling.Requirements included the appropriate label, but wasn't able to make it work. I'm afraid this one is outside of my wheelhouse 😅

[jmdeal]

No problem, I'll go ahead and merge a test into this PR later today and we can get this merged.

[jmdeal]

Sorry for the delay, made a couple additional changes and this should be good to go from my perspective. Since I've touched the PR though I shouldn't be the one to approve, I'm going to get review from someone else on the team. We should be able to merge this shortly