Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix doc link references to preview #6793

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #6790

Description

Fixes references that were erroneously overridden from preview to v1.0.0

How was this change tested?

  • make presubmit
  • Viewed the preview docs

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner August 18, 2024 00:33
Copy link

netlify bot commented Aug 18, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit f994ba2
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66c1413fe1c5a0000867cc1b
😎 Deploy Preview https://deploy-preview-6793--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonathan-innis jonathan-innis enabled auto-merge (squash) August 18, 2024 00:34
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10436377530

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 79.264%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 91.67%
Totals Coverage Status
Change from base Build 10436342271: -0.01%
Covered Lines: 5921
Relevant Lines: 7470

💛 - Coveralls

Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit e284774 into aws:main Aug 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong url for getting-started-with-karpenter/cloudformation.yaml for v.1.0.0
3 participants