Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong url for getting-started-with-karpenter/cloudformation.yaml for v.1.0.0 #6790

Closed
ybezsonov opened this issue Aug 17, 2024 · 1 comment · Fixed by #6793
Closed

Wrong url for getting-started-with-karpenter/cloudformation.yaml for v.1.0.0 #6790

ybezsonov opened this issue Aug 17, 2024 · 1 comment · Fixed by #6793
Labels
documentation Improvements or additions to documentation needs-triage Issues that need to be triaged

Comments

@ybezsonov
Copy link

Description

How can the docs be improved?
Documentation https://karpenter.sh/v1.0/getting-started/getting-started-with-karpenter/ has wrong url to download cloudformation.yaml

Current version has
https://raw.githubusercontent.com/aws/karpenter-provider-aws/v1.0.0/website/content/en/v1.0/getting-started/getting-started-with-karpenter/cloudformation.yaml

Should it be replaced with the url below, like in https://karpenter.sh/v1.0/upgrading/v1-migration/ ?
https://raw.githubusercontent.com/aws/karpenter-provider-aws/v"${KARPENTER_VERSION}"/website/content/en/preview/getting-started/getting-started-with-karpenter/cloudformation.yaml

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@ybezsonov ybezsonov added documentation Improvements or additions to documentation needs-triage Issues that need to be triaged labels Aug 17, 2024
@jonathan-innis
Copy link
Contributor

Yep, this looks wrong. Should be pretty easy to make a fix. I'll throw one up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation needs-triage Issues that need to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants