Provisioner cluster endpoint validation #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 426409a 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/6119c1500d02cc00084a866a |
JacobGabrielson
changed the title
ellistarn
reviewed
Aug 15, 2021
| @@ -20,50 +20,77 @@ cloud.google.com/go/bigquery v1.3.0/go.mod h1:PjpwJnslEMmckchkHFfq+HTD2DmtT67aNF | |||
| cloud.google.com/go/bigquery v1.4.0/go.mod h1:S8dzgnTigyfTmLBfrtrhyYhwRxG72rYxvftPBK2Dvzc= | |||
| cloud.google.com/go/bigquery v1.5.0/go.mod h1:snEHRnqQbz117VIFhE8bmtwIDY80NLUZUMb4Nv6dBIg= | |||
| cloud.google.com/go/bigquery v1.7.0/go.mod h1://okPTzCYNXSlb24MZs83e2Do+h+VXtc4gLoIoXIAPc= | |||
| cloud.google.com/go/bigquery v1.8.0 h1:PQcPefKFdaIzjQFbiyOgAqyx8q5djaE7x9Sqe712DPA= | |||
There was a problem hiding this comment.
Curious what caused all these changes.
There was a problem hiding this comment.
I don't know - is it important?
ellistarn
reviewed
Aug 15, 2021
| // url.Parse() will accept a lot of input without error; make | ||
| // sure it's a real URL | ||
| if err != nil || !endpoint.IsAbs() || endpoint.Hostname() == "" { | ||
| errs = errs.Also(apis.ErrInvalidValue(c.Endpoint, "endpoint")) |
There was a problem hiding this comment.
Can you write in a helpful message about what it should be (e.g. a valid uri). IIRC, you can put this message into the .Also()
ellistarn
reviewed
Aug 15, 2021
| } { | ||
| badCluster := cluster | ||
| badCluster.Endpoint = endpoint | ||
| provisioner.Spec.Cluster = badCluster |
There was a problem hiding this comment.
nit:
provisioner.Spec.Cluster = &ClusterP{
Endpoint: endpoint
}
or
provisioner.spec.Cluster.Endpoint = endpoint
9306b3b to
212c44b
Compare
ellistarn
approved these changes
Aug 16, 2021
gfcroft
pushed a commit
to gfcroft/karpenter-provider-aws
that referenced
this pull request
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue, if available:
#600
Description of changes:
Make sure Provisioner.Cluster.Endpoint is a valid absolute URL and at least has a hostname.
Testing: unit test plus example bad input detection in running cluster:
Produces expected error from webhook in logs:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.