Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation for Cluster.Endpoint #600

Closed
ellistarn opened this issue Aug 9, 2021 · 0 comments · Fixed by #618
Closed

Validation for Cluster.Endpoint #600

ellistarn opened this issue Aug 9, 2021 · 0 comments · Fixed by #618
Assignees
@JacobGabrielson
Labels
bug Something isn't working

Comments

@ellistarn
Copy link
Contributor

ellistarn commented Aug 9, 2021 •
edited
Loading

Version

Karpenter: v0.0.0

Kubernetes: v1.0.0

Expected Behavior

cluster.endpoint = NON COMPLIANT HTTP URI
The webhook should reject the request.

Actual Behavior

Things just break.
@ellistarn ellistarn added the bug Something isn't working label Aug 9, 2021
@JacobGabrielson JacobGabrielson self-assigned this Aug 9, 2021
@JacobGabrielson JacobGabrielson mentioned this issue Aug 14, 2021
Merged
@JacobGabrielson JacobGabrielson linked a pull request Aug 14, 2021 that will close this issue
Provisioner cluster endpoint validation #618
Merged
gfcroft pushed a commit to gfcroft/karpenter-provider-aws that referenced this issue Nov 25, 2023
@jonathan-innis
chore: Change deprovisioning to disruption controller and add metrics (…
7dcc61d 
…aws#600)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobGabrielson JacobGabrielson

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provisioner cluster endpoint validation JacobGabrielson/karpenter
2 participants
@JacobGabrielson @ellistarn