Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix daemonset sensitive tests #6123

Merged
merged 1 commit into from
May 2, 2024
Merged

test: fix daemonset sensitive tests #6123

merged 1 commit into from
May 2, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented May 1, 2024

Fixes #N/A

Description
Fixes several tests which are sensitive to the number of daemonsets in the test environment. This is due to assumptions about the size of node a given pod would fit on. This assumption was broken by #5982 which added an additional daemonset.

How was this change tested?
karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner May 1, 2024 03:17
@jmdeal jmdeal requested a review from engedaam May 1, 2024 03:17
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link

netlify bot commented May 1, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 7a111d1
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6633202b9a46de00085a4762

Copy link
Contributor

github-actions bot commented May 1, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-22ed4b18b3e4adccf272bd0e5b4a26d472217f6a.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-22ed4b18b3e4adccf272bd0e5b4a26d472217f6a" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

coveralls commented May 1, 2024

Pull Request Test Coverage Report for Build 8918917930

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.088%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 8914365316: -0.02%
Covered Lines: 5403
Relevant Lines: 6582

💛 - Coveralls

@jmdeal jmdeal force-pushed the test-fix branch 2 times, most recently from 0129d90 to d25daf5 Compare May 1, 2024 18:08
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit 896ae3d into aws:main May 2, 2024
17 checks passed
@jmdeal jmdeal deleted the test-fix branch May 9, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants