Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Forward Container logs for E2E tests #5982

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Apr 4, 2024

Fixes #N/A

Description

  • Add log forwarding for containers to CloudWatch

How was this change tested?

  • Tested in a forked repo

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner April 4, 2024 16:41
@engedaam engedaam requested a review from ljosyula April 4, 2024 16:41
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit ca5b725
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/662966d9f275d10008f4161d

@engedaam engedaam force-pushed the log-forwarding branch 8 times, most recently from f11c6dd to 86e1ff5 Compare April 4, 2024 20:32
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post the result of getting these logs back in the description? I also don't think this is going to give us Karpenter logs out of the box. I'm imagining that there's a bunch of additional configuration that you have to do the fluentbit container so that we ensure that it ships logs specifically from our application

.github/actions/e2e/setup-cluster/action.yaml Outdated Show resolved Hide resolved
.github/actions/e2e/setup-cluster/action.yaml Outdated Show resolved Hide resolved
@jonathan-innis
Copy link
Contributor

I think that the CWA will send back metrics as well by default. How do we ensure that we are not double-sending metrics with our current prometheus agent and the CWA? Also, maybe something to look into, is there a way to integrate the CWA with AMP so that we don't need the separate prometheus instance running on the cluster?

@coveralls
Copy link

coveralls commented Apr 5, 2024

Pull Request Test Coverage Report for Build 8822660261

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 81.978%

Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 8811887111: -0.02%
Covered Lines: 5395
Relevant Lines: 6581

💛 - Coveralls

@engedaam engedaam force-pushed the log-forwarding branch 6 times, most recently from 39dc5c8 to 7e75406 Compare April 6, 2024 15:38
Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@engedaam engedaam force-pushed the log-forwarding branch 6 times, most recently from 593fdfc to 71fcaee Compare April 23, 2024 17:22
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit b103ff0 into aws:main Apr 24, 2024
17 checks passed
@engedaam engedaam deleted the log-forwarding branch April 24, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants