-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Forward Container logs for E2E tests #5982
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
f11c6dd
to
86e1ff5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you post the result of getting these logs back in the description? I also don't think this is going to give us Karpenter logs out of the box. I'm imagining that there's a bunch of additional configuration that you have to do the fluentbit container so that we ensure that it ships logs specifically from our application
I think that the CWA will send back metrics as well by default. How do we ensure that we are not double-sending metrics with our current prometheus agent and the CWA? Also, maybe something to look into, is there a way to integrate the CWA with AMP so that we don't need the separate prometheus instance running on the cluster? |
Pull Request Test Coverage Report for Build 8822660261Details
💛 - Coveralls |
39dc5c8
to
7e75406
Compare
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
593fdfc
to
71fcaee
Compare
71fcaee
to
ca5b725
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #N/A
Description
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.