-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update spot pricing even in Isolated VPC #5704
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Pull Request Test Coverage Report for Build 8104908898Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Make sure you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the change!
@liafizan Did you validate this on your own private cluster? |
Use pr feedback Co-authored-by: Jonathan Innis <[email protected]>
Synced with upstream
Hey @jonathan-innis. I tested my changes in local cluster. Though not exhaustive but I can validate |
revert website preview changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes ##5587
Description
Spot pricing uses EC2 api and a check in code base disabled spot pricing check when
--isolated-vpc
flag was used. Removed condition which will allow spot prices to be updated when inisolated-vpc
How was this change tested?
Manual testing. Tried adding a test in pricing suite but it did not help since pricing controller itself was enabled which deemed this test unnecessary.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.