Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover Spot Instance Pricing in Isolated VPCs #5587

Open
jonathan-innis opened this issue Feb 2, 2024 · 4 comments
Open

Discover Spot Instance Pricing in Isolated VPCs #5587

jonathan-innis opened this issue Feb 2, 2024 · 4 comments
Labels
feature New feature or request good-first-issue Good for newcomers

Comments

@jonathan-innis
Copy link
Contributor

jonathan-innis commented Feb 2, 2024

Description

What problem are you trying to solve?

Currently, if you set the --isolated-vpc setting, you won't get any pricing information discovered and Karpenter will fully rely on statically created pricing information that is shipped with Karpenter on each release. We made this decision since the AWS price list API is only available in a smaller set of regions; however, this API is only used to discover on-demand pricing information. Spot pricing information is discovered through EC2, which does have a VPC private endpoint.

We can allow spot pricing information to be retrieved, even when you have the --isolated-vpc setting set.

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@jonathan-innis jonathan-innis added feature New feature or request good-first-issue Good for newcomers labels Feb 2, 2024
@liafizan
Copy link
Contributor

working on this.

@gmembre-zenika
Copy link

It would be great if karpenter can use a proxy for outgoing traffic to query this API. The cluster I work on are located in eu-west-3, the isolated-vpc option is set and the pricing api is only available in eu-central-1 and we don't want to setup a new VPC just for it.

@liafizan
Copy link
Contributor

@gmembre-zenika I think what you are requesting might be another feature request. Perhaps a good idea to open a new request so that it can be tracked based on consensus

@fedecz
Copy link
Contributor

fedecz commented Sep 25, 2024

hey @jonathan-innis , @liafizan , has PR #5704 fixed this issue? if so, could we close it? Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good-first-issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants