Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Adding contents permission to E2E testing for release-v0.31.x #5635

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Feb 8, 2024

Fixes #N/A

Description

  • adding contents permission to E2E testing

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner February 8, 2024 21:56
@engedaam engedaam requested a review from bwagner5 February 8, 2024 21:56
@coveralls
Copy link

coveralls commented Feb 8, 2024

Pull Request Test Coverage Report for Build 7836456776

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.216%

Totals Coverage Status
Change from base Build 7835347379: 0.0%
Covered Lines: 6872
Relevant Lines: 8160

💛 - Coveralls

@engedaam engedaam changed the title ci: Adding contents permission to E2E testing for release-v0.31.x ci: Adding contents permission to E2E testing for release-v0.31.x Feb 8, 2024
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit e232f21 into aws:release-v0.31.x Feb 8, 2024
9 checks passed
@engedaam engedaam deleted the add-contents-permission branch February 8, 2024 23:04
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
johngmyers added a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
Merge in DEL/karpenter-fork from upgrade-31-4 to main

* commit '4f1e7c0ea99fb9fb5399fb3178cb054ba4210869':
  chore: Bump karpenter for v0.31.4 (aws#5641)
  test: Fix E2E test for `release-v0.31.x` (aws#5639)
  ci: Adding `contents` permission to E2E testing for `release-v0.31.x` (aws#5635)
  ci: Fix permission on E2E for the `release-v0.31.x` (aws#5634)
  ci: Port workflow fixes for `release-v0.31.x` (aws#5627)
  ci: Add trigger release branch (aws#5626)
  ci: Allow ci to run on `release-v0.31.x` (aws#5625)
  fix: Fix retrieving NodePool when rolling back to v0.31.x (aws#5621)
  chore: release v0.31.3 (aws#5206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants