Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix retrieving NodePool when rolling back to v0.31.x #5621

Merged

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Feb 7, 2024

Fixes #5613

Description

This fixes an issue where a user has deployed a NodeClaim to their cluster with a Node and a NodeClaim that has entered a terminating state. This ensures that we don't try to retrieve the parent NodePool information for the Node when we are getting the node from the CloudProvider.

How was this change tested?

make apply and validate rollback scenario

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, something went wrong.

@jonathan-innis jonathan-innis requested a review from a team as a code owner February 7, 2024 06:06
@jonathan-innis jonathan-innis enabled auto-merge (squash) February 7, 2024 06:06

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ation
@jonathan-innis jonathan-innis merged commit e23df76 into aws:release-v0.31.x Feb 7, 2024
8 checks passed
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
johngmyers added a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
Merge in DEL/karpenter-fork from upgrade-31-4 to main

* commit '4f1e7c0ea99fb9fb5399fb3178cb054ba4210869':
  chore: Bump karpenter for v0.31.4 (aws#5641)
  test: Fix E2E test for `release-v0.31.x` (aws#5639)
  ci: Adding `contents` permission to E2E testing for `release-v0.31.x` (aws#5635)
  ci: Fix permission on E2E for the `release-v0.31.x` (aws#5634)
  ci: Port workflow fixes for `release-v0.31.x` (aws#5627)
  ci: Add trigger release branch (aws#5626)
  ci: Allow ci to run on `release-v0.31.x` (aws#5625)
  fix: Fix retrieving NodePool when rolling back to v0.31.x (aws#5621)
  chore: release v0.31.3 (aws#5206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants