Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update E2E testing to use Pod Identity #5262

Merged
merged 1 commit into from
Dec 7, 2023
Merged

ci: Update E2E testing to use Pod Identity #5262

merged 1 commit into from
Dec 7, 2023

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Dec 6, 2023 •
edited
Loading

Fixes #5264

Description

How was this change tested?

  • Forked account

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify Netlify
Copy link

netlify bot commented Dec 6, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit ce8f88a
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65711d24d7cdb20008eb6f7d

engedaam
engedaam commented Dec 6, 2023
View reviewed changes
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

engedaam
engedaam commented Dec 6, 2023
View reviewed changes
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@coveralls
Copy link

coveralls commented Dec 6, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7122451138

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.472%
Totals Coverage Status
Change from base Build 7122410692: 0.0%
Covered Lines: 4917
Relevant Lines: 5962
💛 - Coveralls

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-7d183d3dfb3a45dd2f91764908cd2b45019be593.

@engedaam engedaam force-pushed the use-pod-identity branch 3 times, most recently from fbe0c80 to c6defc2 Compare December 6, 2023 23:57
@engedaam engedaam marked this pull request as ready for review December 7, 2023 00:13
@engedaam engedaam requested a review from a team as a code owner December 7, 2023 00:13
@engedaam engedaam requested a review from njtran December 7, 2023 00:13
njtran
njtran previously approved these changes Dec 7, 2023
View reviewed changes
jonathan-innis
jonathan-innis previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🎉 I assume that we are taking a separate PR to update the Getting Started Guide for the v0.33 docs?

@engedaam
Copy link
Contributor Author

engedaam commented Dec 7, 2023

Yup! #5259

@engedaam engedaam dismissed stale reviews from jonathan-innis and njtran via 2b516d4 December 7, 2023 01:03
@engedaam engedaam force-pushed the use-pod-identity branch 2 times, most recently from 2b516d4 to 4144d0b Compare December 7, 2023 01:14
jonathan-innis
jonathan-innis approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉

@engedaam engedaam merged commit 77d2753 into aws:main Dec 7, 2023
12 checks passed
@engedaam engedaam deleted the use-pod-identity branch December 8, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@njtran njtran njtran left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update E2E Testing to use Pod Identity instead of IRSA
4 participants
@engedaam @coveralls @njtran @jonathan-innis