Chore: Tighten RBAC permissions #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
suket22
reviewed
Jun 17, 2022
| - apiGroups: ["admissionregistration.k8s.io"] | ||
| resources: ["validatingwebhookconfigurations", "mutatingwebhookconfigurations"] | ||
| verbs: ["get", "watch", "list"] | ||
| # Write |
There was a problem hiding this comment.
Nice, I like that we're separating out the Read and Write permissions!
Comment on lines
17
to
19
| - apiGroups: [""] | ||
| resources: ["namespaces"] | ||
| resources: ["configmaps", "namespaces", "secrets"] | ||
| verbs: ["get", "list", "watch"] |
There was a problem hiding this comment.
Can we scope this down to the specific ConfigMaps (logging, batchingConfig) and Secrets that we need via resourceNames ?
There was a problem hiding this comment.
I believe you can't restrict list requests by resource name, but we need list/watch for the informer. Since these are read permissions, I think this is acceptable.
There was a problem hiding this comment.
If we can't restrict list, can we atleast restrict get and watch?
There was a problem hiding this comment.
Created the role
- apiGroups: [""]
resources: ["configmaps"]
verbs: ["get", "list", "watch"]
resourceNames:
- karpenter-global-settings
- karpenter-leader-election
- config-logging
karpenter-6746fb6c66-m7ttl controller E0621 17:29:47.216205 1 reflector.go:138] k8s.io/[email protected]/tools/cache/reflector.go:167: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: configmaps is forbidden: User "system:serviceaccount:karpenter:karpenter" cannot list resource "configmaps" in API group "" in the namespace "karpenter"
Get is subsumed by list, so I don't see the value in restricting get.
suket22
approved these changes
Jun 21, 2022
|
Chart Version: 0.12.0 |
This was referenced Jul 13, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #973
Description
Tighten RBAC permissions
How was this change tested?
make testmake applyDoes this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.