Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add docs for customAMIs, tests for UserData #2169

Merged
merged 5 commits into from
Jul 26, 2022
Merged

docs: Add docs for customAMIs, tests for UserData #2169

merged 5 commits into from
Jul 26, 2022

Conversation

suket22
Copy link
Contributor

@suket22 suket22 commented Jul 21, 2022 •
edited
Loading

  • docs: Add docs for customAMIs, tests for UserData

Description

  • Added a couple of integration tests to verify merging of UserData
  • Added docs for the Custom AMI feature.

How was this change tested?

  • Ran make website and made sure the links look good. Hopefully I've fixed all typos.
  • Ran the integration tests and made sure they succeeded. Takes ~120 seconds.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

docs: Add docs for customAMIs, tests for UserData

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@suket22 suket22 requested a review from a team as a code owner July 21, 2022 23:35
@suket22 suket22 requested a review from bwagner5 July 21, 2022 23:35
@netlify
Copy link

netlify bot commented Jul 21, 2022 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 95ffb6a
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62df29b6e3678f000922ef05
😎 Deploy Preview https://deploy-preview-2169--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ellistarn
ellistarn previously approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Remaining comments are optional.

bwagner5
bwagner5 approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@suket22 suket22 merged commit 1d3159c into aws:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

@ellistarn ellistarn ellistarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suket22 @ellistarn @bwagner5