fix: properly quote Bottlerocket config #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In TOML, bare keys have limitations in the keys that they can contain ([A-Za-z0-9_-]) and strings _must_ be quoted. This change quotes all keys to properly handle e.g. node labels with slashes in them and also adds missing quotes for node taint values.
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: aabe61c 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/621642ecab667900084ea473 |
|
Approach looks good. Definitely needs to be tested. |
|
I was able to reproduce a provisioner with a taint defined and a bottlerocket node not coming online in the current main branch. I installed your patches on the cluster and did another scale-up with the same provisioner and observed the nodes going to "Ready". |
|
@bwagner5 LGTM then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
#1404
2. Description of changes:
In TOML, bare keys have limitations in the keys that they can contain
([A-Za-z0-9_-]) and strings must be quoted. This change quotes all
keys to properly handle e.g. node labels with slashes in them and also
adds missing quotes for node taint values.
3. How was this change tested?
Manually, see #1406 (comment)
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.