Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amiFamily: Bottlerocket does not properly quote keys/vals in toml userdata, leading to nodes failing to join the cluster #1404

Closed
SohumB opened this issue Feb 22, 2022 · 0 comments
Closed

amiFamily: Bottlerocket does not properly quote keys/vals in toml userdata, leading to nodes failing to join the cluster #1404

SohumB opened this issue Feb 22, 2022 · 0 comments
Assignees
@bwagner5
Labels
bug Something isn't working burning Time sensitive issues

Comments

@SohumB
Copy link

SohumB commented Feb 22, 2022

Version

Karpenter: v0.6.3

Kubernetes: v1.21

Expected Behavior

Nodes join the cluster regardless of taints :)

Actual Behavior

If you have a provisioner with both amiFamily: Bottlerocket and a taint, Karpenter can generate an invalid toml file for the userdata, looking something like:

[settings.kubernetes.node-taints]
example.com/requires-x86=:NoSchedule

This should be

[settings.kubernetes.node-taints]
"example.com/requires-x86"=":NoSchedule"

Steps to Reproduce the Problem

Resource Specs and Logs
@SohumB SohumB added the bug Something isn't working label Feb 22, 2022
@ellistarn ellistarn added the burning Time sensitive issues label Feb 22, 2022
@DWSR DWSR mentioned this issue Feb 23, 2022
Merged
3 tasks
@bwagner5 bwagner5 self-assigned this Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwagner5 bwagner5

Labels
bug Something isn't working burning Time sensitive issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SohumB @ellistarn @bwagner5