re-enable the PDB eviction test #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 1f52116 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/620aa62b3d026300087dedad |
ellistarn
reviewed
Feb 14, 2022
| // kube-controller-manager normally does this, but we don't have one. If this isn't modified | ||
| // the eviction controller assumes that the PDB hasn't been processed by the disruption controller | ||
| // yet and adds a 10 second retry to our evict() call | ||
| pdb.Status.ObservedGeneration = 1 |
There was a problem hiding this comment.
Can we include this in the test.PodDisruptionBudget library? We will then need to use ExpectCreatedWithStatus on it.
There was a problem hiding this comment.
Yup, done, the update call required the ResourceVersion to match, I thought that was with everything so I'm not sure why it only showed up for the PDB.
ellistarn
reviewed
Feb 14, 2022
tzneal
force-pushed
the
fix-638-reenable-pdb-eviction-test
branch
from
3ace514 to
ee5c7aa
Compare
ellistarn
reviewed
Feb 14, 2022
ellistarn
previously approved these changes
Feb 14, 2022
- the pod must be in a non-pending state for eviction to consider the PDB - the Status.ObservedGeneration must be >= the pdb.Generation or the eviction results in a 429 retry with a 10 second delay Fixes aws#638
tzneal
force-pushed
the
fix-638-reenable-pdb-eviction-test
branch
from
ee5c7aa to
1f52116
Compare
ellistarn
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
#638
2. Description of changes:
3. How was this change tested?
Unit testing
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.