Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable PDB Eviction Test #638

Closed
ellistarn opened this issue Aug 25, 2021 · 0 comments
Closed

Reenable PDB Eviction Test #638

ellistarn opened this issue Aug 25, 2021 · 0 comments
Assignees
@njtran
Labels
operational-excellence
Milestone
v0.4.0

Comments

@ellistarn
Copy link
Contributor

This test was removed in #637
@ellistarn ellistarn added the bug Something isn't working label Aug 25, 2021
@ellistarn ellistarn added this to the v0.4.0 milestone Aug 25, 2021
@ellistarn ellistarn removed the bug Something isn't working label Jan 7, 2022
tzneal added a commit to tzneal/karpenter that referenced this issue Feb 14, 2022
@tzneal
re-enable the PDB eviction test
594f147 
- the pod must be in a non-pending state for eviction
  to consider the PDB
- the Status.ObservedGeneration must be >= the pdb.Generation
  or the eviction results in a 429 retry with a 10 second delay


Fixes aws#638
tzneal added a commit to tzneal/karpenter that referenced this issue Feb 14, 2022
@tzneal
re-enable the PDB eviction test
3ace514 
- the pod must be in a non-pending state for eviction
  to consider the PDB
- the Status.ObservedGeneration must be >= the pdb.Generation
  or the eviction results in a 429 retry with a 10 second delay

Fixes aws#638
@tzneal tzneal mentioned this issue Feb 14, 2022
Merged
3 tasks
tzneal added a commit to tzneal/karpenter that referenced this issue Feb 14, 2022
@tzneal
re-enable the PDB eviction test
ee5c7aa 
- the pod must be in a non-pending state for eviction
  to consider the PDB
- the Status.ObservedGeneration must be >= the pdb.Generation
  or the eviction results in a 429 retry with a 10 second delay

Fixes aws#638
tzneal added a commit to tzneal/karpenter that referenced this issue Feb 14, 2022
@tzneal
re-enable the PDB eviction test
1f52116 
- the pod must be in a non-pending state for eviction
  to consider the PDB
- the Status.ObservedGeneration must be >= the pdb.Generation
  or the eviction results in a 429 retry with a 10 second delay

Fixes aws#638
gfcroft pushed a commit to gfcroft/karpenter-provider-aws that referenced this issue Nov 25, 2023
@jonathan-innis
chore: Only consider node shape for requested resources (aws#638)
8c11172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njtran njtran

Labels
operational-excellence
Projects
None yet
Milestone
v0.4.0
Development

No branches or pull requests
2 participants
@ellistarn @njtran