Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottlerocket nvidia #1331

Merged
merged 4 commits into from
Feb 12, 2022
Merged

Bottlerocket nvidia #1331

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eba0f5d
Add bottlerocket lookup for nvidia and arm64 AMIs
rothgar Feb 11, 2022
65aa9d0
Add docs update for bottlerocket amifamily
rothgar Feb 11, 2022
f43dd2a
Separate GPU and arch checks for bottlerocket
rothgar Feb 11, 2022
df1156a
Remove AWSNeurons check for BR AMI
rothgar Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/cloudprovider/aws/ami.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,14 @@ func (p *AMIProvider) getAL2Alias(version string, instanceType cloudprovider.Ins
// getBottlerocketAlias returns a properly-formatted alias for a Bottlerocket AMI from SSM
func (p *AMIProvider) getBottlerocketAlias(version string, instanceType cloudprovider.InstanceType) string {
arch := "x86_64"
amiSuffix := ""
if !instanceType.NvidiaGPUs().IsZero() || !instanceType.AWSNeurons().IsZero() {
amiSuffix = "-nvidia"
bwagner5 marked this conversation as resolved.
Show resolved Hide resolved
}
if instanceType.Architecture() == v1alpha5.ArchitectureArm64 {
arch = instanceType.Architecture()
}
return fmt.Sprintf("/aws/service/bottlerocket/aws-k8s-%s/%s/latest/image_id", version, arch)
return fmt.Sprintf("/aws/service/bottlerocket/aws-k8s-%s%s/%s/latest/image_id", version, amiSuffix, arch)
}

// getUbuntuAlias returns a properly-formatted alias for an Ubuntu AMI from SSM
Expand Down
2 changes: 1 addition & 1 deletion website/content/en/preview/AWS/provisioning.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ spec:

The AMI used when provisioning nodes can be controlled by the `amiFamily` field. Based on the value set for `amiFamily`, Karpenter will automatically query for the appropriate [EKS optimized AMI](https://docs.aws.amazon.com/eks/latest/userguide/eks-optimized-amis.html) via AWS Systems Manager (SSM).

Currently, Karpenter supports `amiFamily` values `al2`, `bottlerocket`, and `ubuntu`. GPUs are only supported with `al2`.
Currently, Karpenter supports `amiFamily` values `al2`, `bottlerocket`, and `ubuntu`. GPUs are only supported with `al2` and `bottlerocket`.

Note: If a custom launch template is specified, then the AMI value in the launch template is used rather than the `amiFamily` value.

Expand Down