Bottlerocket nvidia #1331
Merged
Bottlerocket nvidia #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: df1156a 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/6206f3286d6097000732e759 |
bwagner5
reviewed
Feb 11, 2022
ellistarn
requested changes
Feb 11, 2022
I've tested manually. Scaled up an nvidia gpu request on both amd64 and arm64 w/ Bottlerocket 🚀 |
ellistarn
approved these changes
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
If the AMI family type used is Bottlerocket and the instance type is an NVIDIA GPU instance the drivers are not available in the generic Bottlerocket AMI. The lookup for arm64 architecture was also dependent on GPU instances but they're not mutually exclusive (eg G5g).
2. Description of changes:
This adds a lookup for Bottlerocket AMIs to use the
-nvidiavariant along with arm64 AMI when needed.3. How was this change tested?
I based the code off the existing AL2 lookups and ran linting and basic tests but did not have the infrastructure in place to deploy it into a live cluster.
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.