Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "switch to python 3.8 (#4239)" #4317

Merged
merged 1 commit into from
Nov 6, 2023
Merged

revert: "switch to python 3.8 (#4239)" #4317

merged 1 commit into from
Nov 6, 2023

Conversation

mikewrighton
Copy link
Contributor

This reverts commit 087ff24.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 6, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2023

The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged.
[Conventional Commits]: https://www.conventionalcommits.org

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2023

The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged.
[Conventional Commits]: https://www.conventionalcommits.org

@otaviomacedo otaviomacedo changed the title Revert "chore: switch to python 3.8 (#4239)" revert: "switch to python 3.8 (#4239)" Nov 6, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Nov 6, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2023

Merging (with squash)...

@mergify mergify bot merged commit 90ce1da into main Nov 6, 2023
34 of 36 checks passed
@mergify mergify bot deleted the revert-4239-corymhall/build-python3.8 branch November 6, 2023 16:19
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Nov 6, 2023
@mrgrain
Copy link
Contributor

mrgrain commented Nov 14, 2023

This was reverted because our internal build & release pipeline failed. After some investigation this was because the internal job used a superchain image with python3.7. However after this change a minimum version of python 3.8 is required.

@mrgrain
Copy link
Contributor

mrgrain commented Nov 14, 2023

Re-roll: #4327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaviomacedo otaviomacedo otaviomacedo approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikewrighton @mrgrain @otaviomacedo