-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch to python 3.8 #4239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the minimum version of python that jsii supports? I'm not sure what that is, it's not transparent in the jsii or CDK docs. Can we answer that before making a decision on this? We should be testing with the minimum version of python that is supported.
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Merging (with squash)... |
This reverts commit 087ff24.
This reverts commit 087ff24. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Python 3.7 has been end-of-life since 2023-06-27, and an increasing amount of our dependencies are dropping support for it as a consequence. We introduced a warning to users that are still using Python 3.7 with release v1.86.0 around August 1, 2023. We are now effectively dropping support for Python 3.7. Related: 0ef7ace BREAKING CHANGE: jsii-pacmak and the libraries it generates for Python targets now require a minimum Python version of 3.8, instead of 3.7 previously. We recommend users upgrade to the latest supported Python release (Python 3.11). --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Python 3.7 has been end-of-life since 2023-06-27, and an increasing amount of our dependencies are dropping support for it as a consequence. We introduced a warning to users that are still using Python 3.7 with release v1.86.0 around August 1, 2023. We are now effectively dropping support for Python 3.7. Related: 0ef7ace Re-roll of #4239, which was reverted because the build & release pipeline failed. After some investigation this was because the job used a superchain image with python3.7. However after this change a minimum version of python 3.8 is required. BREAKING CHANGE: jsii-pacmak and the libraries it generates for Python targets now require a minimum Python version of 3.8, instead of 3.7 previously. We recommend users upgrade to the latest supported Python release (Python 3.11). --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Python 3.7 has been end-of-life since 2023-06-27, and an
increasing amount of our dependencies are dropping support for it as a
consequence.
We introduced a warning to users that are still using Python 3.7 with
release v1.86.0 around August 1, 2023.
We are now effectively dropping support for Python 3.7.
Related: 0ef7ace
BREAKING CHANGE: jsii-pacmak and the libraries it generates for Python
targets now require a minimum Python version of 3.8, instead of 3.7
previously. We recommend users upgrade to the latest supported Python
release (Python 3.11).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.