fix: typesVersions not respecting outDir from tsconfig file #1238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1234
Also fixes an issue related the
.type-compat
output path that was discovered when adding tests. When gettingoutdir
from the program, this might be either a relative or absolute path. Previously the code assumed it was always relative which is not correct. This led to absolute paths being used for the.type-compat
dir and in the post processing; ultimately leading to a compilation failure. The fix is to ensureoutdir
&.type-compat
are normalized to a relative path.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.