-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BYO tsconfig - typesVersions not respecting outDir in tsconfig file #1234
Comments
Closed
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 13, 2024
Fixes #1234 Also fixes an issue related the `.type-compat` output path that was discovered when adding tests. When getting `outdir` from the program, this might be either a relative or absolute path. Previously the code assumed it was always relative which is not correct. This led to absolute paths being used for the `.type-compat` dir and in the post processing; ultimately leading to a compilation failure. The fix is to ensure `outdir` & `.type-compat` are normalized to a relative path. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
aws-cdk-automation
pushed a commit
that referenced
this issue
Aug 13, 2024
Fixes #1234 Also fixes an issue related the `.type-compat` output path that was discovered when adding tests. When getting `outdir` from the program, this might be either a relative or absolute path. Previously the code assumed it was always relative which is not correct. This led to absolute paths being used for the `.type-compat` dir and in the post processing; ultimately leading to a compilation failure. The fix is to ensure `outdir` & `.type-compat` are normalized to a relative path. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit 072239b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am using the new
tsconfig
option. In mytsconfig.json
, I haveoutDir
set tolib
. I have not changed mytsconfig.json
file at all from the JSII-generatedtsconfig.json
.If I set
outDir
in mytsconfig.json
to some value other than"."
, thetypesVersions
key inpackage.json
references the wrong path:I can get around this by setting my
jsii
config section to this:but I think ideally JSII should use the
outDir
from the BYO tsconfig if possible.The text was updated successfully, but these errors were encountered: