Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(task): run task in environment #1155

Merged
merged 11 commits into from
Jul 16, 2020
Merged

chore(task): run task in environment #1155

merged 11 commits into from
Jul 16, 2020

Conversation

Louise15926
Copy link
Contributor

This PR implements a task runner that runs tasks in a copilot environment.

Related #702

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Louise15926 Louise15926 requested a review from a team as a code owner July 16, 2020 15:55
@Louise15926 Louise15926 requested a review from kohidave July 16, 2020 15:55
@Louise15926 Louise15926 requested review from efekarakus and piradeepk and removed request for kohidave July 16, 2020 15:55
@Louise15926 Louise15926 changed the title chore(chore): run task in environment chore(task): run task in environment Jul 16, 2020
efekarakus
efekarakus reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@efekarakus efekarakus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! just a minor comment for moving the constants around

internal/pkg/task/env_runner.go Outdated Show resolved Hide resolved
internal/pkg/task/env_runner.go Outdated Show resolved Hide resolved
internal/pkg/task/env_runner.go Outdated Show resolved Hide resolved
piradeepk
piradeepk requested changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Since you're already making errors constants, can we make all errors constants? That way, if we need to update the string, we would only need to change it in one place, not multiple places.

efekarakus
efekarakus approved these changes Jul 16, 2020
View reviewed changes
internal/pkg/task/task.go Outdated Show resolved Hide resolved
internal/pkg/task/task.go Outdated Show resolved Hide resolved
@efekarakus efekarakus added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 16, 2020
bvtujo
bvtujo reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@bvtujo bvtujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, just a small comment.

internal/pkg/task/env_runner.go Show resolved Hide resolved
piradeepk
piradeepk approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💯

@Louise15926 Louise15926 removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 16, 2020
@mergify mergify bot merged commit 585bbcd into aws:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piradeepk piradeepk piradeepk approved these changes

@bvtujo bvtujo bvtujo approved these changes

@efekarakus efekarakus efekarakus approved these changes

@iamhopaul123 iamhopaul123 Awaiting requested review from iamhopaul123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Louise15926 @efekarakus @bvtujo @piradeepk @Lou1415926