chore(task): run task in provided subnets and security groups #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piradeepk
approved these changes
Jul 15, 2020
efekarakus
approved these changes
Jul 15, 2020
| m.EXPECT().DefaultCluster().Return("cluster-1", nil) | ||
| }, | ||
| mockStarter: func(m *mocks.MocktaskRunner) { | ||
| m.EXPECT().RunTask(ecs.RunTaskInput{ |
There was a problem hiding this comment.
nit: we can use gomock.Any() here for the failure scenario since the test case tests the behavior of what happens on any run task err.
There was a problem hiding this comment.
! will address this in the next PR on task package
Louise15926
pushed a commit
to Louise15926/amazon-ecs-cli-v2
that referenced
this pull request
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a task runner that runs tasks in user provided subnets and security groups.
Related #702
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.