Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proper TraceID in dummy segments #223

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Added proper TraceID in dummy segments #223

merged 2 commits into from
Apr 24, 2020

Conversation

bhautikpip
Copy link
Contributor

@bhautikpip bhautikpip commented Apr 24, 2020

Issue #, if available:

Description of changes:

Added call to generate proper TraceID in Dummy Segment case. Tested this change with listQueues AWS SDK downstream call.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bhautikpip bhautikpip requested a review from willarmiros April 24, 2020 18:59
@codecov-io
Copy link

codecov-io commented Apr 24, 2020

Codecov Report

Merging #223 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   84.53%   84.60%   +0.06%     
==========================================
  Files          80       80              
  Lines        3130     3131       +1     
==========================================
+ Hits         2646     2649       +3     
+ Misses        484      482       -2     
Impacted Files Coverage Δ
aws_xray_sdk/core/models/dummy_entities.py 86.66% <100.00%> (+0.30%) ⬆️
aws_xray_sdk/core/sampling/local/reservoir.py 100.00% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d12c83...2ae9e4d. Read the comment docs.

@bhautikpip bhautikpip merged commit 672062f into aws:master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants