Added proper TraceID in dummy segments (#223)

* Added proper TraceID in dummy segments * Added test case to check valid TraceID
aws · Apr 24, 2020 · 672062f · 672062f
1 parent 2d12c83
commit 672062f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/aws_xray_sdk/core/models/dummy_entities.py b/aws_xray_sdk/core/models/dummy_entities.py
@@ -1,3 +1,4 @@
+from .traceid import TraceId
 from .segment import Segment
 from .subsegment import Subsegment
 
@@ -13,7 +14,7 @@ class DummySegment(Segment):
     """
     def __init__(self, name='dummy'):
 
-        super(DummySegment, self).__init__(name=name, traceid='dummy')
+        super(DummySegment, self).__init__(name=name, traceid=TraceId().to_id())
         self.sampled = False
 
     def set_aws(self, aws_meta):

diff --git a/tests/test_dummy_entites.py b/tests/test_dummy_entites.py
@@ -3,7 +3,6 @@
 
 
 def test_not_sampled():
-
     segment = DummySegment()
     subsegment = DummySubsegment(segment)
 
@@ -12,7 +11,6 @@ def test_not_sampled():
 
 
 def test_no_ops():
-
     segment = DummySegment()
     segment.put_metadata('key', 'value')
     segment.put_annotation('key', 'value')
@@ -63,3 +61,12 @@ def test_invalid_entity_name():
 
     assert segment.name == 'DummySegment Test'
     assert subsegment.name == 'DummySubsegment'
+
+
+def test_dummy_segment_trace_id():
+    segment = DummySegment()
+
+    assert segment.trace_id != 'dummy'
+    assert '-' in segment.trace_id
+    # checking version of trace id
+    assert segment.trace_id[:1] == '1'